[virt-tools-list] [PATCH] Show disk allocation & size on Details tab in VMM

[Michal Novotny]

Hi Haydn,
you were right. It was not working right in some circumstances - the values of allocation & size were not reset when type was not 'file' and this is the corrected version of this patch. Thanks once again Haydn...

Thanks,
Michal

----- Original Message -----
From: "Haydn Solomon" <haydn.solomon at gmail.com>
To: "Michal Novotny" <minovotn at redhat.com>
Cc: virt-tools-list at redhat.com
Sent: Tuesday, August 4, 2009 6:29:41 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna
Subject: Re: [virt-tools-list] [PATCH] Show disk allocation & size on Details  tab in VMM

Michael, 

Thanks for your patch. I have one comment based on my observation. I noticed that if the cdrom is not connected, it shows the capacity of the primary disk. The cdrom source type shows as block when disconnected but file when connected. 




On Tue, Aug 4, 2009 at 12:02 PM, Michal Novotny < minovotn at redhat.com > wrote: 


Hi, 
sorry, I made a mistake here preventing it to show size and even work correctly in some circumstances, this is updated version of this patch. 

Thanks, 
Michal 




----- Original Message ----- 
From: "Michal Novotny" < minovotn at redhat.com > 
To: virt-tools-list at redhat.com 
Sent: Tuesday, August 4, 2009 5:39:23 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna 
Subject: [virt-tools-list] [PATCH] Show disk allocation & size on Details tab in VMM 

Hi, 
this is a patch for virt-manager (VMM for short) that allows user see the current allocation and disk size. It's working fine for both managed and unmanaged storages, however getting allocation information is possible only for managed ones so that there is just "N/A" string shown in disk allocation field if looking on unmanaged storage details. It's also showing disk size of CD-ROM devices assigned for this VM... 

Please review, thanks, 
Michal 
_______________________________________________ 
virt-tools-list mailing list 
virt-tools-list at redhat.com 
https://www.redhat.com/mailman/listinfo/virt-tools-list 
_______________________________________________ 
virt-tools-list mailing list 
virt-tools-list at redhat.com 
https://www.redhat.com/mailman/listinfo/virt-tools-list 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: vmm-details-disk-size-alloc.patch
Type: text/x-patch
Size: 8878 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20090805/73ff4282/attachment.bin>