[virt-tools-list] [PATCHWORK] [virt-manager] fullscreen behaviour

[Cole Robinson]

On 11/12/2009 02:02 PM, Jon Nordby wrote:
> On Thu, Nov 12, 2009 at 5:59 PM, Cole Robinson <crobinso at redhat.com> wrote:
> 
>>>   #TODO: kill details window on destruction
>>
>> What does this mean exactly?
>>
> It is now possible to focus the window for the menu and close it with a
> keystroke. The console will still be up, fullscreened, and with no obvious
> way to control it. So on closing this window I think the console/details
> window should be closed as well. Or alternatively go out of fullscreen mode,
> putting the menu back in place.
> 

Hmm, maybe we should just find a way to prevent the menu from ever being
destroyed.

> On Thu, Nov 12, 2009 at 5:59 PM, Cole Robinson <crobinso at redhat.com> wrote:
> 
>>>   #TODO: actually not centered?
>>>
>>> Not neccesary imo, but nice to have (especially the first):
>>>   #NICE: add a button for getting out of fullscreen
>>
>> Where would the button go? A separate window, or just a top level menu
>> entry?
> 
>> Thoughts, comments?
>>
>> I tried it out, I like the direction its going in! I know the comments
>> above indicate that the alignment isn't quite right, but is this what
>> you are seeing?
>>
>> http://fedorapeople.org/~crobinso/tmp/win-fullscreen.png<http://fedorapeople.org/%7Ecrobinso/tmp/win-fullscreen.png>
>>
>> Particularly the distance from the top of the screen. Is that
>> intentional? I'm running on fedora rawhide FYI.
>>
> 
> No, I intended for it to be at the very top, and works as expected here. I
> suspect you are running GNOME with a panel at the top? If so, could you test
> if it is positioned correctly when you move the panel to the bottom?

Good call, I'm using GNOME with a top panel. Hopefully there is an easy
way to work around it.

> Here is a screenshot of what I see now + a very smooth mockup for the
> button: http://omploader.org/vMnI2NQ
> I also intend for it to be centered horizontally so that the center of
> widget is at the center of the screen.
> 
> Out of curiousity, what does virtual box do here? (you indicated you
>> were familiar with it). I'll try to take some time to set up vmware
>> workstation and vbox to play with it. There seems like several ways we
>> could possibly tweak this behavior, and I'm interested what the
>> precedent is.
>>
> 
> Virtualbox has a dedicated menubar for this. It has menus for basic vm
> control, the name of the vm, a button to "pin" (disable autohide). Autohide
> is enabled by default, and it also has a delay on hiding the menubar.
> 
> Did you have a specific behaviour in mind?
> 

I just meant small things like length of timeout, menu bar placement,
menu bar content, whether we allow disabling auto hide, whether menu bar
shows immediately or requires some amount of mouse hovering before
showing. I wouldn't want the menu bar popping up to interfere with
someone using an app in their VM.

- Cole