[virt-tools-list] [PATCH] systray: toogle Manager on click and a pref. to keep running in tray

[Jon Nordby]

Patch reworked based upon proposed changes. Much simpler now. No
notification however.

On Tue, Oct 20, 2009 at 5:43 PM, Cole Robinson <crobinso at redhat.com> wrote:

> On 10/19/2009 03:10 PM, Jon Nordby wrote:
> > Result of me scratching an itch and procrastinating on studies. First
> time
> > using hg and glade so bear with me and give feedback if there is anything
> > wrong. Or if there are other things that should/could be improved.
> >
> > I believe this addresses the minimal case for: "System Icon Improvements
> -
> > At the very least, a "Minimize to Tray" type option." on
> > http://virt-manager.et.redhat.com/page/Roadmap
> > The "Keep running in tray" option should however be grayed out when the
> > systray is disabled to not confuse the user. I was not able to find out
> how
> > that's done.
> >
>
> Thanks for taking a stab at this.
>
> I regret even adding the systray icon without making your proposed
> behavior the default. I think the icon is only useful for people who
> plan on having the virt-manager as a long running task, and we shouldn't
> require that some top level window stay minimize that whole time.
>
> So, I don't think this should even be an opt out option, let's just out
> right enable it! This will simplify your patch substantially (though it
> was fine to begin with).
>
> The one extra piece to facilitate this will be a notification that
> 'virt-manager is still running' when the user closes all windows, with a
> 'Don't show this again' option. Though it's not required to commit this
> patch.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20091021/8709f8d3/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: systray_toggle_keep_running.patch
Type: application/octet-stream
Size: 3167 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20091021/8709f8d3/attachment.obj>