[virt-tools-list] A trivial patch for virt-install: fix errors if 'perms=rw' storage configuration option was specified

Satoru SATOH satoru.satoh at gmail.com
Tue Oct 26 13:23:00 UTC 2010


virt-install(1) says perms=rw is the default configuration for this
storage option.  Unfortunatelly, there is no code block handling this
case, so error occurs if 'perms=rw' was passed.

Here is a fix for this problem for virt-install in python-virtinst.


diff -r 427edbbe98f6 virt-install
--- a/virt-install	Sun Oct 24 21:04:06 2010 +0000
+++ b/virt-install	Tue Oct 26 21:58:08 2010 +0900
@@ -322,6 +322,8 @@
                 ro = True
             elif opt_val == "sh":
                 shared = True
+            elif opt_val == "rw":
+                pass  # It's default. Nothing to do.
             else:
                 fail(_("Unknown '%s' value '%s'" % (opt_type, opt_val)))
         elif opt_type == "size":




More information about the virt-tools-list mailing list