[virt-tools-list] [PATCH 0/4] virt-manager: a few spicevmc usage fixes

[Cole Robinson]

On 04/04/2011 07:35 PM, Marc-André Lureau wrote:
> Hi!
> 
> The following patches fix and improve adding and 
> removing Spice agent channel (spicevmc).
> 
> It requires a patch in virt-inst:
> https://www.redhat.com/archives/virt-tools-list/2011-April/msg00002.html
> 
> cheers
> 
> Marc-André Lureau (4):
>   addhardware: allow setting the char device target name
>   addhardware: fix adding and removing a channel device
>   details: show char device target name
>   details: propose to add or remove Spice agent when switching
>

Thanks, pushed.

I needed a small fix to patch 2 to avoid a traceback in the logs when
first running the addhw wizard.

I improved the metric in patch 4 a bit. If switching to spice, only
prompt the user if a spicevmc channel doesn't already exist, only offer
to remove spicevmc if one actually exists, etc.

- Cole

>  src/virtManager/addhardware.py |   42 +++++++++++++++++++++++++++------------
>  src/virtManager/details.py     |   17 ++++++++++++++-
>  src/virtManager/domain.py      |   18 +++++++++++++++-
>  src/vmm-add-hardware.glade     |   30 +++++++++++++++++++++++++++-
>  src/vmm-details.glade          |   35 ++++++++++++++++++++++++++++++--
>  5 files changed, 121 insertions(+), 21 deletions(-)
>