[virt-tools-list] [PATCH virt-manager v3] Add inspection to virt-manager

Cole Robinson crobinso at redhat.com
Mon Jul 18 18:35:11 UTC 2011


On 07/18/2011 10:18 AM, Richard W.M. Jones wrote:
> Comments on the previous patches are here:
> https://www.redhat.com/archives/virt-tools-list/2011-July/thread.html#00016
> 
> This updated patch series makes all of the changes outlined in the
> previous replies, with the exception below.
> 
> In patch 3/4 (see [1]) I *didn't* combine the inspection-changed and
> config-changed signals.  I think if I did this, then we'd end up
> redrawing the icon every second for every VM (right?)  Even if it was
> cached, this seems like a waste.
> 
> Rich.
> 
> [1] https://www.redhat.com/archives/virt-tools-list/2011-July/msg00018.html
> 

Good point.

Series looks fine besides the comments on patch #1

Thanks,
Cole




More information about the virt-tools-list mailing list