[virt-tools-list] [PATCH] Add a 'class' attribute to OS

[Daniel P. Berrange]

On Wed, Jun 29, 2011 at 05:55:11PM +0300, Zeeshan Ali (Khattak) wrote:
> From: "Zeeshan Ali (Khattak)" <zeeshanak at gnome.org>
> 
> This is the generic family this OS belongs to, for example Linux, Windows,
> Solaris, UNIX etc.
> ---
>  data/oses/bsd.xml                     |    4 ++
>  data/oses/centos.xml                  |    2 +
>  data/oses/debian.xml                  |    3 +
>  data/oses/fedora.xml                  |   11 +++++
>  data/oses/generic-linux.xml           |    5 ++
>  data/oses/mandriva.xml                |    4 ++
>  data/oses/others.xml                  |    4 ++
>  data/oses/rhel.xml                    |    9 ++++
>  data/oses/solaris.xml                 |    3 +
>  data/oses/suse.xml                    |    2 +
>  data/oses/ubuntu.xml                  |    8 ++++
>  data/oses/windows.xml                 |    8 ++++
>  docs/reference/Libosinfo-sections.txt |    1 +
>  osinfo/libosinfo.syms                 |    1 +
>  osinfo/osinfo_loader.c                |    1 +
>  osinfo/osinfo_os.c                    |   66 ++++++++++++++++++++++++++++++++-
>  osinfo/osinfo_os.h                    |    3 +
>  17 files changed, 133 insertions(+), 2 deletions(-)
> 
> diff --git a/data/oses/bsd.xml b/data/oses/bsd.xml
> index e6ba331..355f6b5 100644
> --- a/data/oses/bsd.xml
> +++ b/data/oses/bsd.xml
> @@ -5,6 +5,7 @@
>      <name>FreeBSD 6</name>
>      <version>6.4</version>
>      <vendor>FreeBSD Project</vendor>
> +    <family>UNIX</family>
>  
>      <devices>
>        <device id="http://pciids.sourceforge.net/v2.2/pci.ids/10ec/8029"/>
> @@ -16,6 +17,7 @@
>      <name>FreeBSD 7</name>
>      <version>7.4</version>
>      <vendor>FreeBSD Project</vendor>
> +    <family>UNIX</family>
>      <upgrades id="http://freebsd.org/freebsd6"/>
>    </os>
>  
> @@ -24,6 +26,7 @@
>      <name>FreeBSD 8</name>
>      <version>8.2</version>
>      <vendor>FreeBSD Project</vendor>
> +    <family>UNIX</family>
>      <upgrades id="http://freebsd.org/freebsd7"/>
>  
>      <devices>
> @@ -35,6 +38,7 @@
>      <short-id>openbsd4</short-id>
>      <name>OpenBSD 4</name>
>      <version>4.9</version>
> +    <family>UNIX</family>
>      <vendor>OpenBSD Project</vendor>
>  
>      <devices>

Perhaps we should let BSD have a family of 'BSD' ?

ACK to the patch either way though

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|