[virt-tools-list] [RFC 1 of2] adding 802.1Qbg VSI type support to virtinst and virtmanager

[Gerhard Stenzel]

On Mon, 2011-03-07 at 13:45 -0500, Cole Robinson wrote:
...
> Your mailer busted the patch. Easiest solution is to just attach the patch.

ok, attached this time

...
> This part should be dropped.
done

...
> _alter_compare should only be called once at the end of the function, it
> compares the guest instance that we altered against the expected output file.
> In fact I'm surprised calling it twice like this actually works: is python
> setup.py test actually passing?
> 
> You should probably also be checking all the new interface properties you are
> adding, like
> 
> check("vsi_managerid", "12", "15")
> 
> or similar.
> 
> Additionally, take a look at the _make_checker definition, that last
> assertEquals is redundant.

partially done. I have to admit I don't fully understand yet how the
tests work ... i just copied and modified.

...
> 
> I think I asked this before, but is it possible that an interface can have
> more than 1 virtualport? If not now then in the future? If so, it might be
> better to make a class InterfaceVirtualPort or something, and have the
> VirtualInterface carry a list of those.

the virtual interface of a VM can have one virtual port. But I am happy
to make such a class, if you point me to an example (I am not really a
python expert).

> Thanks,
> Cole

Thanks for your comments so far ..

-- 
Best regards, 

Gerhard Stenzel, 
-----------------------------------------------------------------------------------------------------------------------------------
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add_vsi_types.patch
Type: text/x-patch
Size: 5342 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20110308/ae938987/attachment.bin>