[virt-tools-list] [PATCH 02/12] Add virt_viewer_session_open_uri

[Marc-André Lureau]

On Thu, Jan 26, 2012 at 4:55 PM, Daniel P. Berrange <berrange at redhat.com> wrote:
>
> I'm more in favour of the former, so that we have direct access
> to the various parts of the URI internally whenever we need them.

Spice uri have various parts that don't need to be parsed but only by spice-gtk.

For example, the ports are specified using "port="  and "tls-port="
arguments. We want to add further connexion parameters there,
specifying which channel should be secured, what compression should be
used etc..

I think the URI representation should be kept instead, and use a GUri
kind of API that would make it easy to extract its several parts.
Unfortunately, GUri isn't yet available.

So for now, it looks like the best option is to have both. Either
specify the URI or the various components. I made a patch that uses
URI only, but it's not convenient as gtk-vnc and libvirt don't use URI
notation, and we need to convert back and forth in various places (see
attach patch)

-- 
Marc-André Lureau
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-virt_viewer_session_open_uri.patch
Type: text/x-patch
Size: 15651 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20120127/74c15faf/attachment.bin>