[virt-tools-list] [PATCH virt-viewer 12/17] Resize guest desktop with SPICE

Daniel P. Berrange berrange at redhat.com
Tue Jan 31 15:50:09 UTC 2012


On Tue, Jan 31, 2012 at 04:48:32PM +0100, Marc-André Lureau wrote:
> On Tue, Jan 31, 2012 at 3:18 PM, Daniel P. Berrange <berrange at redhat.com>wrote:
> 
> > This prevents the zoom in/out functionality from working, so I removed
> > that.
> >
> 
> What doesn't work? Without this change, the viewer keeps resizing the
> display, and this causes the display to grow and grow in a loop.
> 
> Spice-gtk doesn't know what is the current "wanted" scaling factor, and
> virt-viewer tries to maintain it, which causes that loop of resize events.

Hmm, that sounds like a bug.

> That's why it should reset the zoom level to 1.0 when the guest resolution
> is changed.

If you start virt-viewer with --zoom 25, then it should remain at 1/4
of the guest resolution at all times. That change caused it to ignore
the requested zoom level.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the virt-tools-list mailing list