[virt-tools-list] [PATCH 08/10] Add desktop profile for Fedora 15 and newer

[Zeeshan Ali (Khattak)]

On Sun, Jul 1, 2012 at 10:36 PM, Fabiano Fidêncio <fabiano at fidencio.org> wrote:
> On Wed, Jun 13, 2012 at 7:16 AM, Daniel P. Berrange <berrange at redhat.com> wrote:
>> On Mon, Jun 11, 2012 at 11:23:09PM -0300, Fabiano Fidêncio wrote:
>>> +# Set user avatar
>>> +mkdir /mnt/unattended-media
>>> +mount /dev/sda /mnt/unattended-media
>>> +cp /mnt/unattended-media/<xsl:value-of select="config/user-login"/> /var/lib/AccountsService/icons/
>>> +umount /mnt/unattended-media
>>
>> Interesting. So to use the Fedora desktop profile, an application needs
>> to already know that they must provide a 'sda' hard disk, containing
>> a filesystem containing a specially named icon file.....
>
> To be honest, it is part of set_direct_boot_params() function, that
> will be moved from gnome-boxes to libosinfo, IIUC.
> I think we can leave it as is, at least for now. But, of course, I
> really want to read your opinion.

He already gave you his opinion: We can't make those assumptions in
libosinfo. While Boxes may or may not be the primary user of
libosinfo, we need to keep the API generic enough for other apps too.
We can't leave this as is since this will be broken for every other
app but Boxes. Also things don't remain the same in Boxes so the next
time the VM configuration code changes, nobody would remember to
update this code in libosinfo and we'll have mysterious issues at our
hand.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124