[virt-tools-list] [PATCH 3/6] Change install script output (tool)

[Daniel P. Berrange]

On Wed, Jul 25, 2012 at 04:43:34PM +0200, Fabiano Fidêncio wrote:
> On Wed, Jul 25, 2012 at 4:37 PM, Daniel P. Berrange <berrange at redhat.com> wrote:
> > On Wed, Jul 25, 2012 at 04:27:01PM +0200, Fabiano Fidêncio wrote:
> >> On Wed, Jul 25, 2012 at 3:14 PM, Daniel P. Berrange <berrange at redhat.com> wrote:
> >> >
> >> >> If the dirname argument is NULL, the output files will be written in the
> >> >> current directory.
> >> >
> >> > I think we could probably just make that an parameter flag
> >> > instead eg.
> >> >
> >> >    # osinfo-install-script --output-dir /some/dir  win2k3r2
> >> >
> >>
> >> eorry, i didn't understand your point.
> >> could you try to clarify it a bit more for me?
> >
> > IIUC, currently you have  output dir as a parameter
> >
> >    # osinfo-install-script  OSNAME FILENAME  OUTPUT-DIR
> >
> > I'm suggesting using a flag
> >
> >    # osinfo-install-script --output-dir OUTPUT-DIR OSNAME
> 
> As I did, we have:
> 
> # osinfo-install-script --output-dir OUTPUT-DIR --output-file FILENAME OSNAME
> 
> we agreed in remove --output-file, right?

Yes.

> about output dir i'm working in this way:
> if OUTPUT-DIR is passed, the path will be OUTPUT-DIR, else, the path will be "."
> do you agree with this behavior?

Ok, yes, that's good. I was mis-reading the options you had
configured. Sorry for the confusion


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|