[virt-tools-list] [PATCH 3/4] install script: add install_script_avatar entity

[Zeeshan Ali (Khattak)]

On Mon, Oct 22, 2012 at 5:28 PM, Zeeshan Ali (Khattak)
<zeeshanak at gnome.org> wrote:
> On Mon, Oct 22, 2012 at 5:28 PM, Fabiano Fidêncio <fabiano at fidencio.org> wrote:
>> On Mon, Oct 22, 2012 at 12:16 PM, Zeeshan Ali (Khattak)
>> <zeeshanak at gnome.org> wrote:
>>> On Sun, Oct 21, 2012 at 7:08 AM, Fabiano Fidêncio <fabiano at fidencio.org> wrote:
>>>> Firstly, sorry for a too late reply. :(
>>>>
>>>> On Tue, Aug 28, 2012 at 11:03 AM, Zeeshan Ali (Khattak)
>>>> <zeeshanak at gnome.org> wrote:
>>>>> On Tue, Aug 28, 2012 at 5:43 AM, Fabiano Fidêncio <fabiano at fidencio.org> wrote:
>>>>>> On Mon, Aug 27, 2012 at 8:14 PM, Zeeshan Ali (Khattak)
>>>>>> <zeeshanak at gnome.org> wrote:
>>>>>>> On Tue, Aug 28, 2012 at 1:54 AM, Fabiano Fidêncio <fabiano at fidencio.org> wrote:
>>>>>>>> On Mon, Aug 27, 2012 at 7:43 PM, Zeeshan Ali (Khattak)
>>>>>>>> <zeeshanak at gnome.org> wrote:
>>>>>>>>> On Tue, Aug 28, 2012 at 12:57 AM, Fabiano Fidêncio <fabiano at fidencio.org> wrote:
>>>>>>>>>> On Mon, Aug 27, 2012 at 6:03 PM, Zeeshan Ali (Khattak)
>>>>>>>>>> <zeeshanak at gnome.org> wrote:
>>>>>>>>>>> On Sun, Aug 26, 2012 at 11:50 AM, Fabiano Fidêncio <fabiano at fidencio.org> wrote:
>>>>>>>>>>>> Add a new entity called OsinfoInstallScriptAvatar to help the creation
>>>>>>>>>>>> of an Avatar file for an install script. If avatar entity needs to be
>>>>>>>>>>>> set, just add, in the .xml's script file:
>>>>>>>>>>>> <avatar>
>>>>>>>>>>>>     <image-type>...</image-type>
>>>>>>>>>>>>     <extension>...</extension>
>>>>>>>>>>>>     <alpha>...</alpha>
>>>>>>>>>>>>     <width>...</width>
>>>>>>>>>>>>     <height>...</height>
>>>>>>>>>>>> </avatar>
>>>>>>>>>>>
>>>>>>>>>>> I don't quit follow one major thing here: What is the direction of the
>>>>>>>>>>> OsinfoInstallScriptAvatar? Is app setting it on libosinfo or app
>>>>>>>>>>> getting it from libosinfo? How would a typical usage look like?
>>>>>>>>>>
>>>>>>>>>> App is getting it from libosinfo. With this entity, we can drop
>>>>>>>>>> AvatarFormat boxes' class and get this info from install-script.
>>>>>>>>>
>>>>>>>>> Ah ok so its all about script telling app that if it needs to add a
>>>>>>>>> user avatar, which format it needs to be in? If so, how does app know
>>>>>>>>> which filename to use with avatar?
>>>>>>>>
>>>>>>>> How is it done in gnome-boxes?
>>>>>>>
>>>>>>> You are writing the Boxes patch so you tell me. :) If you are asking
>>>>>>> about existing code, it simply uses the username + extention as the
>>>>>>> filename. We'll need a way to create/get avatar filename for/to the
>>>>>>> application. My idea would be to treat this similar to how we deal
>>>>>>> with windows XP's .cmd and .reg files. They are not scripts either but
>>>>>>> we treat them as such.
>>>>>>>
>>>>>>> BTW, how does this patch work with your avatar releted code in commit 1d9822ae ?
>>>>>>
>>>>>> Hmmm. Looks like we need to improve OsinfoInstallScriptAvatar to
>>>>>> support, beyond what is supported:
>>>>>> - mount point
>>>>>
>>>>> Thats very much specific to boxes code.
>>>>>
>>>>>> - source path
>>>>>> - destination path
>>>>
>>>> So, we will keep only these info:
>>>> - filename
>>>> - disk
>>>> - image-type
>>>> - extension (optional, default value is "")
>>>> - alpha
>>>> - width (optional, default value is -1)
>>>> - height (optional, default value is -1)
>>>
>>> Yes except that disk is supposed to be a config prop/param, not avatar.
>>
>> Right!
>>
>>>
>>>>>   * config parameter to specify avatar filename/path. In fedora.xml,
>>>>> you can then replace:
>>>> filename *and* path? should be just filename, right?
>>>
>>> A '/' means "or" (or at least whats I think it means). In above
>>> context "whatever the exact name".
>>
>> Okay, filename should include the entire path to the image as I thought.
>
> If by image, you mean the avatar file yes and the path inside the
> avatar-disk (not the host as copying to the disk should be completely
> left to app).

I just realized that this avatar is different case than our scripts in
the sense that OS doesn't know about it being on the unattended disk
and we copy the avatar manually so filename and extention are
redundant here as we can give any name to the avatar file as we need
from the scripts.

Sorry to ask you to change this once again but nothing very difficult,
just drop these paremeters/properties (both from code and xml).

I'll soon be submitting a patch to add API for apps to specify avatar
disk and location to the script.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124