[virt-tools-list] [libosinfo v6] Make 'filename' more consistent w/ other restrictions

Michal Privoznik mprivozn at redhat.com
Mon Nov 19 17:04:28 UTC 2012


On 14.11.2012 16:30, Zeeshan Ali (Khattak) wrote:
> From: "Zeeshan Ali (Khattak)" <zeeshanak at gnome.org>
> 
> 'filename' should be toplevel node under 'install-script' rather than
> an attribute of its toplevel 'template' child. The reason this was
> previously put in the incorrect place was that the first idea was to have
> multiple files under one install script but we later decided to go for 1
> file per install script.
> 
> Also note that I'm naming the element to 'expected-filename'. This is
> to make it consistent with associated API and to simplify loading code.
> ---
>  data/install-scripts/fedora.xml           |  6 ++++--
>  data/install-scripts/windows-cmd.xml      |  3 ++-
>  data/install-scripts/windows-reg.xml      |  3 ++-
>  data/install-scripts/windows-sif.xml      |  6 ++++--
>  data/install-scripts/windows-unattend.xml |  6 ++++--
>  data/schemas/libosinfo.rng                |  6 +++++-
>  osinfo/osinfo_loader.c                    | 10 +---------
>  7 files changed, 22 insertions(+), 18 deletions(-)

ACK

Michal




More information about the virt-tools-list mailing list