[virt-tools-list] [PATCH virt-viewer 5/7] Add VirtViewerSession:file property

Christophe Fergeau cfergeau at redhat.com
Tue Nov 27 09:45:59 UTC 2012


On Fri, Nov 23, 2012 at 01:41:10PM +0100, Marc-André Lureau wrote:
> If VirtViewerSession:file is set, it should be used to define the
> connection parameters. Also correct the mime type used in this case.

A bit confused by the commit log, use of the file to define the connection
parameters is done in the next commit. The 'Also' is a clear hint that this
commit should be split, and it would have been nice to explain why this
mime type is needed in the log.

Looks good otherwise, ACK.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20121127/04c00912/attachment.sig>


More information about the virt-tools-list mailing list