[virt-tools-list] [virt-viewer] Don't free SPICE ticket twice

Christophe Fergeau cfergeau at redhat.com
Mon Oct 1 16:26:06 UTC 2012


Commit 2201a5a was supposed to free a SPICE ticket leak, but it's
actually introducing a double-free as the SPICE ticket is
unconditionally freed at the end of
virt_viewer_session_spice_main_channel_event
---
 src/virt-viewer-session-spice.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/virt-viewer-session-spice.c b/src/virt-viewer-session-spice.c
index 870bd87..cc20ad8 100644
--- a/src/virt-viewer-session-spice.c
+++ b/src/virt-viewer-session-spice.c
@@ -354,7 +354,6 @@ virt_viewer_session_spice_main_channel_event(SpiceChannel *channel G_GNUC_UNUSED
             gboolean openfd;
 
             g_object_set(self->priv->session, "password", password, NULL);
-            g_free(password);
             g_object_get(self->priv->session, "client-sockets", &openfd, NULL);
 
             if (openfd)
-- 
1.7.12.1




More information about the virt-tools-list mailing list