[virt-tools-list] [PATCH virt-viewer] spice: only autoresize once with screen size in fullscreen

Christophe Fergeau cfergeau at redhat.com
Thu Oct 18 08:51:17 UTC 2012


On Thu, Oct 18, 2012 at 10:44:09AM +0200, Marc-André Lureau wrote:
> Hi
> 
> On Thu, Oct 18, 2012 at 10:14 AM, Christophe Fergeau
> <cfergeau at redhat.com> wrote:
> >> +    if (self->priv->auto_resize == AUTO_RESIZE_FULLSCREEN) {
> >> +        GdkScreen *screen = gtk_widget_get_screen(GTK_WIDGET(self));
> >> +        dw = gdk_screen_get_width(screen);
> >> +        dh = gdk_screen_get_height(screen);
> >> +    }
> >> +
> >>      if (virt_viewer_display_get_zoom(VIRT_VIEWER_DISPLAY(self))) {
> >>          zoom = virt_viewer_display_get_zoom_level(VIRT_VIEWER_DISPLAY(self));
> >
> > After setting dw/dh to the size of the screen, we then apply the zoom level
> > to it. Are we guaranteed that zoom will disabled or less than 100 at this
> > point, or should we ignore zoom after going fullscreen?
> 
> Imho, zoom should still be applied.

Even if it's more than 100? Will the behaviour be sane if this happens? I'm
fine with it if things don't break ;)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20121018/61c80288/attachment.sig>


More information about the virt-tools-list mailing list