[virt-tools-list] [PATCH virt-viewer] Use a mutex to check if VirtViewer running, v2

Christophe Fergeau cfergeau at redhat.com
Mon Oct 22 07:47:05 UTC 2012


Hey,

Patch looks good, one question below:

On Sat, Oct 20, 2012 at 01:21:10AM +0200, Marc-André Lureau wrote:
> +Function .onInit
> +retry:
> + System::Call 'kernel32::CreateMutexA(i 0, i 0, t "VirtViewerMutex") i .r1 ?e'

I don't really understand the i.r1 here, is it needed?
http://nsis.sourceforge.net/Allow_only_one_installer_instance also warns
against CreateMutexA when using a unicode nsis, have you checked the mutex
name or are you sure we are not using a unicode nsis?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20121022/a1c2dbe8/attachment.sig>


More information about the virt-tools-list mailing list