[virt-tools-list] [PATCH virt-viewer] Don't fail early if virDomainOpenGraphics fails

Guido Günther agx at sigxcpu.org
Mon Oct 22 20:00:41 UTC 2012


virt_viewer_app_open_connection invokes virDomainOpenGraphics which only works
for local connections. Returning after this failure makes us never reach the
ssh part so this unbreaks connections tunneled over ssh.
---
 src/virt-viewer-app.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
index 7dcc4c1..34dcdde 100644
--- a/src/virt-viewer-app.c
+++ b/src/virt-viewer-app.c
@@ -821,8 +821,7 @@ virt_viewer_app_default_activate(VirtViewerApp *self)
     VirtViewerAppPrivate *priv = self->priv;
     int fd = -1;
 
-    if (!virt_viewer_app_open_connection(self, &fd))
-        return -1;
+    virt_viewer_app_open_connection(self, &fd);
 
     DEBUG_LOG("After open connection callback fd=%d", fd);
 
-- 
1.7.10.4




More information about the virt-tools-list mailing list