[virt-tools-list] [PATCH virt-viewer] Fail if neither vnc nor spice is detected

Eric Blake eblake at redhat.com
Tue Oct 23 16:24:24 UTC 2012


On 10/23/2012 02:03 AM, Christophe Fergeau wrote:

>>  
>> +if test "x$have_gtk_vnc" != "xyes" -a "x$have_gtk_spice" != "xyes"; then
> 
> IIRC
> if test "x$have_gtk_vnc" != "xyes" && test "x$have_gtk_spice" != "xyes"; then
> is better as it is more portable.

Correct - POSIX itself recommends against using 'test ... -a ...'

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 617 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20121023/10f2a63d/attachment.sig>


More information about the virt-tools-list mailing list