[virt-tools-list] [PATCH] virt-convert: fix some typos

Cole Robinson crobinso at redhat.com
Thu Sep 6 15:37:51 UTC 2012


On 08/21/2012 11:07 PM, ajia at redhat.com wrote:
> From: Alex Jia <ajia at redhat.com>
> 
> RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=849863
> 
> ---
>  virt-convert |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/virt-convert b/virt-convert
> index 5223771..e3fd301 100755
> --- a/virt-convert
> +++ b/virt-convert
> @@ -115,9 +115,9 @@ def parse_args():
>          options.output_dir = os.path.dirname(os.path.realpath(args[1]))
>  
>      if options.output_format not in formats.formats():
> -        opts.error(_("Unknown output format \"%s\")" % options.output_format))
> +        opts.error(_("Unknown output format \"%s\"") % options.output_format))

There's now an extra ')' character here, breaking 'python setup.py test'.
Please make sure 'python setup.py test' doesn't regress with any change.

- Cole

>      if options.output_format not in formats.output_formats():
> -        opts.error(_("No output handler for format \"%s\")"
> +        opts.error(_("No output handler for format \"%s\"")
>              % options.output_format))
>  
>      if not os.access(args[0], os.R_OK):
> @@ -133,7 +133,7 @@ def parse_args():
>              sys.exit(1)
>  
>      if options.input_format not in formats.formats():
> -        opts.error(_("Unknown input format \"%s\")" % options.input_format))
> +        opts.error(_("Unknown input format \"%s\"") % options.input_format))
>      if options.input_format not in formats.input_formats():
>          opts.error(_("No input handler for format \"%s\"")
>              % options.input_format)
> 




More information about the virt-tools-list mailing list