[virt-tools-list] [PATCH-v5.5 1/5] minor updates and changes to the INSTALL file

[Gene Czarcinski]

On 04/10/2013 05:29 PM, Cole Robinson wrote:
> On 04/09/2013 03:18 PM, Gene Czarcinski wrote:
>> Signed-off-by: Gene Czarcinski <gene at czarc.net>
>> ---
>>   INSTALL | 15 +++++++++++++--
>>   1 file changed, 13 insertions(+), 2 deletions(-)
>>
>> diff --git a/INSTALL b/INSTALL
>> index 1373bc5..c9b29cf 100644
>> --- a/INSTALL
>> +++ b/INSTALL
>> @@ -10,9 +10,20 @@ To install the software into /usr/local (usually), you can do:
>>   
>>       python setup.py install
>>   
>> -To build an RPM, you can run:
>> +To build a basic distribution tarball run:
>>   
>> -    python setup.py run
>> +    python setup.py sdist
>> +
>> +The output of sdist is placed in the ./dist/ directory
>> +
>> +This tarball can be used as the source for a separate directory tree or
>> +can be used to create RPMs:
>> +
>> +    rpmbuild  -ta  --clear  <tarball_produceed_by_sdist>
>> +
>> +To build 'binary' RPMs, you can run:
>> +
>> +    python setup.py rpm
>>   
>>   setup.py generally has all the build and install commands, for more info see:
>>   
>>
> Why document two ways of creating an RPM? I'd like the INSTALL file to be as
> simple as possible, and aimed not at developers but people installing from
> source. For those needs I don't see why people would want to generate a
> tarball, and if they want that they can figure it out with python setup.py
> --help-commands as already documented.
>
> I'll take a patch for the 'binary' clarification and and the 'python setup.py
> run' typo though.
IMHO and YMMV but I believe that git clones of the virt-manager 
repository are more likely to be used by "developer class" users rather 
than user-users.  In any case, I thought that erring on the side of a 
bit more info rather than less info was appropriate.

Regardless, this INSTALL file is missing the information promised in the 
autobuild.sh file.  Since I lack good knowledge of just what that 
information should be, I could not provide it.  Therefore, either update 
INSTALL or delete the reference in autobuild.sh


Gene