[virt-tools-list] [PATCH v6 2/5] automate @VERSION@ in virt-manager.spec

[Gene Czarcinski]

On 04/14/2013 02:32 PM, Cole Robinson wrote:
> On 04/13/2013 05:42 PM, Gene Czarcinski wrote:
>> This update renames virt-manager.spec to be
>> virt-manager.spec.in and changes the version-id to
>> @VERSION@ ... setup.py is modified to copy the
>> virt-manager-spec.in file to virt-manager.spec and
>> replace @VERSION@ with the current/actual version id.
>>
>> .gitignore is updated to ignore virt-manager.spec
>> .
> Something is strange with this. When I download this email and try to 'git am'
> it, git complains like:
>
> fatal: cannot convert from y to UTF-8
>
> If I edit the mail and s/charset=y/charset=UTF-8/ it works. Is it prompting
> you about UTF-8 but you are entering 'y' rather than hitting enter? That's my
> guess anyways.
I screwed up.  First time I ever got a prompt about the character set 
and responded incorrectly.  Will be fixed on resubmit to handle the 
change at the end.
>
>
>
>
>
>> Signed-off-by: Gene Czarcinski <gene at czarc.net>
<snip>
>> +    def run(self):
>> +        ver = cliconfig.__version__
>> +        f1 = open('virt-manager.spec.in', 'r')
>> +        f2 = open('virt-manager.spec', 'w')
>> +        for line in f1:
>> +            f2.write(line.replace('@VERSION@', ver))
>> +        f1.close()
>> +        f2.close()
>> +        sdist.run(self)
>> +
> Then here do sdist_auto.run(self)
>
It seems to work OK as is but it really should be as you state.  I will 
fix, test, and resubmit.

To keep things simple, the resubmit will be for the entire set of 5 
patch files rather than trying to thread updates into the chain.

Gene

Gene