[virt-tools-list] [PATCH 1/2] fix argument error when initializing LibvirtGlib

[Daniel P. Berrange]

On Tue, Apr 16, 2013 at 07:04:12PM +0800, Guannan Ren wrote:
> On 04/15/2013 01:17 AM, Cole Robinson wrote:
> >On 04/12/2013 08:38 AM, Guannan Ren wrote:
> >>Traceback (most recent call last):
> >>   File "./virt-manager", line 351, in <module>
> >>     main()
> >>   File "./virt-manager", line 332, in main
> >>     LibvirtGLib.init(None)
> >>   File "/usr/lib64/python2.7/site-packages/gi/types.py", line 43, in function
> >>     return info.invoke(*args, **kwargs)
> >>TypeError: init() takes exactly 2 arguments (1 given)
> >>
> >>---
> >>  virt-manager | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >>diff --git a/virt-manager b/virt-manager
> >>index 0b8d58b..de80342 100755
> >>--- a/virt-manager
> >>+++ b/virt-manager
> >>@@ -329,7 +329,7 @@ def main():
> >>                                "disabling DBus service")
> >>      # Hook libvirt events into glib main loop
> >>-    LibvirtGLib.init(None)
> >>+    LibvirtGLib.init(0, "")
> >>      LibvirtGLib.event_register()
> >>      # At this point we're either starting a brand new controlling instance,
> >>
> >On F18 this fails, though Dan's original GTK3 patch had the same code, so
> >LibvirtGLib must have fixed this up at some point.
> >
> >What distro are you on? Maybe we can add a version check to catch this, and
> >error out otherwise.
> >
> >- Cole
> 
>     I am using F17, let me check it on F18 later.

Yes, you need to use F18 minimum.

I wonder if we can add a check to virt-manger to validate the min
required gobject library, to avoid these kind of "bug" reports
in the future.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|