[virt-tools-list] [virt-manager PATCH] Describe controller models in virt-install man page

[Martin Kletzander]

On 04/25/2013 07:55 PM, Cole Robinson wrote:
> On 04/25/2013 06:45 AM, Martin Kletzander wrote:
>> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=952086
>>
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>>  man/virt-install.pod | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/man/virt-install.pod b/man/virt-install.pod
>> index 32eabc6..bf00284 100644
>> --- a/man/virt-install.pod
>> +++ b/man/virt-install.pod
>> @@ -847,7 +847,11 @@ a USB2 controller with fallback USB1 support.
>>
>>  =item B<model>
>>
>> -Controller model.
>> +Controller model.  These may vary according to the hypervisor and its
>> +version.  Most commonly used models are e.g. B<auto>, B<virtio-scsi>
>> +for the B<scsi> controller, B<ehci> or B<none> for the B<usb>
>> +controller.  For full list and further details on controllers/models,
>> +see C<http://libvirt.org/formatdomain.html#elementsControllers>.
>>
>>  =item B<address>
>>
> 
> ACK, please push.
> 

Thanks, pushed.

> Would be nice if we got to a point that --controller model=? could print out
> all supported model values. Even better if we could get that info from libvirt
> and not duplicate it internally. But that's not in the near term.
> 

Definitely get the info from libvirt (which we can now partially do from
the RNG scheme, but that seems pretty cumbersome to me).

Martin