[virt-tools-list] [virt-manager][PATCH ] Remove logging_setup, as it is always true.
Cole Robinson
crobinso at redhat.com
Thu Aug 15 01:14:42 UTC 2013
On 08/14/2013 05:31 PM, Leonardo Garcia wrote:
> From: Leonardo Garcia <lagarcia at br.ibm.com>
>
> ---
> virt-manager | 10 ++--------
> 1 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/virt-manager b/virt-manager
> index 1100d23..a6e597c 100755
> --- a/virt-manager
> +++ b/virt-manager
> @@ -37,16 +37,12 @@ from virtinst import cli as virtinstcli
> from virtcli import cliutils, cliconfig
>
>
> -logging_setup = False
> -
> -
> GObject.threads_init()
>
>
> def _show_startup_error(msg, details):
> - if logging_setup:
> - logging.debug("Error starting virt-manager: %s\n%s", msg, details,
> - exc_info=True)
> + logging.debug("Error starting virt-manager: %s\n%s", msg, details,
> + exc_info=True)
> from virtManager.error import vmmErrorDialog
> err = vmmErrorDialog()
> title = _("Error starting Virtual Machine Manager")
> @@ -178,8 +174,6 @@ def main():
> (options, leftovers) = parse_commandline()
>
> virtinstcli.setupLogging("virt-manager", options.debug, False, False)
> - global logging_setup
> - logging_setup = True
>
> import virtManager
> logging.debug("virt-manager version: %s", cliconfig.__version__)
>
Thanks, pushed now.
- Cole
More information about the virt-tools-list
mailing list