[virt-tools-list] [PATCH virt-viewer 11/12] kiosk: explicit resize window to fullscreen size

Daniel P. Berrange berrange at redhat.com
Thu Aug 15 14:50:31 UTC 2013


On Mon, Jul 15, 2013 at 09:36:18PM +0200, Marc-André Lureau wrote:
> Allow to run the client in kiosk mode with window-manager-less
> environment.
> ---
>  src/virt-viewer-window.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
> index 5590443..a4f0973 100644
> --- a/src/virt-viewer-window.c
> +++ b/src/virt-viewer-window.c
> @@ -449,13 +449,10 @@ virt_viewer_window_move_to_monitor(VirtViewerWindow *self)
>  
>      gdk_screen_get_monitor_geometry(gdk_screen_get_default(), n, &mon);
>      gtk_window_move(GTK_WINDOW(priv->window), mon.x, mon.y);
> -#ifdef G_OS_WIN32
> -    /* FIXME: on windows, fullscreen doesn't always hide the taskbar
> -       See https://bugzilla.gnome.org/show_bug.cgi?id=652049 */
> +
>      gtk_widget_set_size_request(GTK_WIDGET(priv->window),
>                                  mon.width,
>                                  mon.height);
> -#endif
>  }

The bug referenced here is still open, but from what you said in the
3rd comment, it seems like it was not a bug after all ? Thus we're
ok re-enabling this code.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the virt-tools-list mailing list