[virt-tools-list] --show-* options are broken

[Cole Robinson]

On 07/10/2013 04:58 PM, Cole Robinson wrote:
> On 07/10/2013 04:50 PM, Leonardo Augusto Guimarães Garcia wrote:
>> Hi Cole,
>>
>> Just FYI, commit 76887c9a3280da32d44d4276135a78d21dd12fe8 broke the --show-*
>> functionality.
>>
>> Traceback (most recent call last):
>>   File "/home/laggarcia/src/git/virt-manager/virtManager/engine.py", line 624,
>> in _show_vm_helper
>>     details = self._get_details_dialog(uri, uuid)
>>   File "/home/laggarcia/src/git/virt-manager/virtManager/engine.py", line 602,
>> in _get_details_dialog
>>     obj = vmmDetails(con.get_vm(uuid))
>>   File "/home/laggarcia/src/git/virt-manager/virtManager/connection.py", line
>> 625, in get_vm
>>     return self.vms[uuid]
>> KeyError: '927c2b5f-ae3a-4f5e-aaeb-4d7fb3846dce'
>>
>> Basically connections vms are not populated yet when trying to open the dialog.
>>
>> I am investigating the issue.
>>
>> Best regards,
>>
> 
> Ah, sorry about that. Likely that we don't synchronously tick() any more when
> connecting to libvirt. We can probably hook to the connection on "vm-added"
> and then perform based on that, I'll poke at it.
> 

Well, the attached patch fixes things. But there are some other issues I'm
just noticing here that stem from not showing the manager window on --show.
Like if something happens that causes us to never show the details window,
like wrong UUID or connection failure, then virt-manager doesn't exit. I don't
have time to look at these right now unfortunately.

- Cole

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-show-options.patch
Type: text/x-diff
Size: 1671 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20130710/55589fe1/attachment.bin>