[virt-tools-list] issue when closing virt-manager

[Cole Robinson]

On 06/13/2013 03:41 AM, Martin Kletzander wrote:
> On 06/13/2013 04:08 AM, Leonardo Augusto Guimarães Garcia wrote:
>> Hey,
>>
>> Not sure why I didn't notice this before, but I just noticed today that
>> when closing virt-manager, if at some point in time the details window
>> has been opened and connected to a running VM, the following warning
>> appears on the log during application shutdown:
>>
>> 2013-06-12 23:00:50,872 (details:587): Closing VM details: <vmmDomain
>> object at 0x320e050 (virtManager+domain+vmmDomain at 0x3060760)>
>> 2013-06-12 23:00:50,885 (engine:324): window counter decremented to 1
>> 2013-06-12 23:00:50,894 (console:198): Shutting down tunnel PID=4596
>> OUTFD=23 ERRFD=25
>> 2013-06-12 23:00:50,899 (console:198): Shutting down tunnel PID=4598
>> OUTFD=26 ERRFD=28
>> 2013-06-12 23:00:50,900 (console:198): Shutting down tunnel PID=4599
>> OUTFD=27 ERRFD=30
>> 2013-06-12 23:00:50,902 (console:198): Shutting down tunnel PID=4601
>> OUTFD=29 ERRFD=32
>> 2013-06-12 23:00:50,902 (console:198): Shutting down tunnel PID=4602
>> OUTFD=31 ERRFD=34
>> 2013-06-12 23:00:50,902 (console:198): Shutting down tunnel PID=4603
>> OUTFD=33 ERRFD=36
>> 2013-06-12 23:00:50,903 (console:1025): Viewer disconnected
>> 2013-06-12 23:00:53,228 (manager:211): Closing manager
>> 2013-06-12 23:00:53,232 (engine:324): window counter decremented to 0
>> 2013-06-12 23:00:53,248 (manager:211): Closing manager
>> 2013-06-12 23:00:53,280 (details:587): Closing VM details: <vmmDomain
>> object at 0x320e050 (virtManager+domain+vmmDomain at 0x3060760)>
>> /usr/lib64/python2.7/site-packages/gi/types.py:47: Warning:
>> g_object_unref: assertion `G_IS_OBJECT (object)' failed
>>   return info.invoke(*args, **kwargs)
>> 2013-06-12 23:00:53,413 (engine:398): Exiting app normally.
>>
>> Notice from the log above that I closed the details window before
>> closing the manager window. At some point during the exit routine it
>> prints the g_object_unref warning. This is not new and I was able to
>> reproduce with quite old commits. Is it a known issue?
>>
> 
> I must say I haven't noticed this either, but now it bothers be every
> time it appears :)  It looks like we are probably not clearing some
> structure which we are consequently cleaning up on the exit (the
> 0x320e050 vmmDetails (and the manager once again) is being closed after
> everything is closed already (proven also by "window counter decremented
> to 0" message).  This was not known to me and fixing this might help
> other issues as well.
> 

It seems harmless actually. I poked at this for far too long and tracked it to
an issue with GDK windows in autodrawer.py. It doesn't look like we are doing
anything wrong, so maybe this is a bug lower in the stack, but I ran out of
patience. For now I pushed a commit that works around the assertion.

- Cole