[virt-tools-list] issues with asyncjob

[Leonardo Augusto Guimarães Garcia]

On 06/17/2013 02:31 PM, Cole Robinson wrote:
> On 06/17/2013 01:17 PM, Leonardo Augusto Guimarães Garcia wrote:
>> Hi Cole,
>>
>> I am recently facing the following issues after the recent changes in asyncjob:
>>
>> 2013-06-17 10:41:33,663 (delete:83): Closing delete wizard
>> 2013-06-17 10:41:33,680 (cliutils:87): Uncaught exception:
>> Traceback (most recent call last):
>>    File "/home/laggarcia/src/git/virt-manager/virtManager/asyncjob.py", line
>> 336, in _pbar_pulse
>>      self.widget("pbar").set_text(progress)
>>    File "/home/laggarcia/src/git/virt-manager/virtManager/baseclass.py", line
>> 189, in widget
>>      return self.builder.get_object(name)
>> AttributeError: 'NoneType' object has no attribute 'get_object'
>>
>> and:
>>
>> Traceback (most recent call last):
>>    File "/home/laggarcia/src/git/virt-manager/virtManager/asyncjob.py", line
>> 342, in _pbar_fraction
>>      self._set_stage_text(stage or _("Processing..."))
>>    File "/home/laggarcia/src/git/virt-manager/virtManager/asyncjob.py", line
>> 219, in _set_stage_text
>>      self.widget("pbar-stage").set_text(text)
>>    File "/home/laggarcia/src/git/virt-manager/virtManager/baseclass.py", line
>> 189, in widget
>>      return self.builder.get_object(name)
>> AttributeError: 'NoneType' object has no attribute 'get_object'
>>
>> This can be reproduced by deleting a VM and by cloning it, respectively.
>>
>> Best regards,
>>
> Hmm, I can't reproduce. Does it happen immediately or at the end of the
> clone/delete process?
>
> Could be that there are idle handlers waiting to be dispatched, but we
> synchronously are doing self.cleanup() from run().
>
> Can you try and turn self.cleanup() into self.idle_add(self.cleanup) and see
> if that fixes your issues? If so please submit a patch.
Cole,

The latest changes you did in asyncjob fixed this issue. Thanks!

Best regards,

Leonardo Garcia
>
> Thanks,
> Cole
>