[virt-tools-list] [PATCH 1/2] error: new helper function to embed customized widget into dialog

[Cole Robinson]

On 06/24/2013 12:13 PM, Leonardo Augusto Guimarães Garcia wrote:
> I am OK with the general idea of your patches.
> 
> Two things that I missed when comparing with virt-viewer similar feature:
> 
> * If the virt-viewer window has the current focus and I insert a USB device,
> it will be automatically redirected to the guest. I was not able to reproduce
> this same test case with virt-manager console viewer. I needed to manually go
> to the menu and select which USB device to redirect. This can be because of
> some configuration with my test environment, but I just would like to confirm
> if this feature is not there.

Hmm, that's interesting, I didn't know about that. I can understand why
virt-viewer/remote-viewer do that since it is used for VDI but I don't think
it fits as well with virt-manager. That said, I'd implement it like
virt-viewer and we can add an option to disable the behavior if anyone
complains convincingly enough.

- Cole