[virt-tools-list] [PATCH 3/3] details: Add auto USB redirection support in console viewer

[Hans de Goede]

Hi,

On 06/27/2013 05:25 AM, Guannan Ren wrote:
> On 06/27/2013 02:51 AM, Leonardo Augusto Guimarães Garcia wrote:

<snip>

> Yeah,   I reported a upstream bug about the issues which can affect the code in this patch.
> https://www.redhat.com/archives/virt-tools-list/2013-June/msg00159.html
> such as, SpiceClientGLib.Channel.string_to_type('usbredir')
>
> In virt-viewer,
> spice_session_has_channel_type(priv->session, SPICE_CHANNEL_USBREDIR);
>
> In spice-gtk python binds
> I didn't find the global variable constant for SPICE_CHANNEL_USBREDIR, so I call string_to_type('usbredir') to get it.
>
> Hans,
> Is there an alternative?

Fix the python bindings ?  Those are not really my area of expertise, but issues
like this one, and UsbDeviceWidget.new not accepting None as second argument, are
issues which should be fixed in the python bindings, rather then working around them.

Regards,

Hans