[virt-tools-list] [PATCH 0/3 virt-manager] Various inspection fixes.

[Richard W.M. Jones]

On Fri, Jun 28, 2013 at 01:11:37PM -0400, Cole Robinson wrote:
> On 06/28/2013 12:57 PM, Richard W.M. Jones wrote:
> > The first two patches are fixes for inspection in virt-manager.
> > 
> > *NB* The third patch is for your entertainment only, and should not be
> > applied.  The reason is that this patch causes random segfaults (but
> > in unrelated code in gtk).  I've tested the Python & libguestfs event
> > mechanism very carefully, so I don't believe this is a libguestfs bug.
> > 
> > I think it might be something to do with threads (is calling
> > logging.debug from another thread safe?), or the general complexity
> > of Gtk3, GObject Introspection and Python.
> 
> Hmm strange. logging.debug should be thread safe. Is the libguestfs callback
> invoked synchronously like the libvirt error reporting callbacks? We've never
> had a problem with those.

Yes, libguestfs callbacks happen synchronously, during libguestfs
calls and in the same thread as the libguestfs call.

For reasons I outlined in the other email, let's not worry about this one :-)

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)