[virt-tools-list] [python-virtinst PATCH] virt-clone: Properly propagate --replace parameter

Cole Robinson crobinso at redhat.com
Fri Mar 1 19:21:03 UTC 2013


On 02/21/2013 10:38 AM, Martin Kletzander wrote:
> Solves https://bugzilla.redhat.com/show_bug.cgi?id=913382
> 
> Due to the '--replace' parameter not being propagated properly, the
> clone of a guest with already existing name fails.
> ---
>  virtinst/CloneManager.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/virtinst/CloneManager.py b/virtinst/CloneManager.py
> index b6b4b46..04692b6 100644
> --- a/virtinst/CloneManager.py
> +++ b/virtinst/CloneManager.py
> @@ -1,4 +1,5 @@
>  #
> +# Copyright 2013  Red Hat, Inc.
>  # Copyright(c) FUJITSU Limited 2007.
>  #
>  # Cloning a virtual machine module.
> @@ -404,6 +405,7 @@ class CloneDesign(object):
> 
>          self._guest = Guest.Guest(conn=self._hyper_conn,
>                                    parsexml=self.original_xml)
> +        self._guest.replace = self.replace
> 
>          # Pull clonable storage info from the original xml
>          self._original_virtual_disks = self._get_original_devices_info()
> 

Thanks Martin, pushed now.

- Cole




More information about the virt-tools-list mailing list