[virt-tools-list] [PATCH virt-viewer 4/4] file: add version field, raise an error if incompatibily

Daniel P. Berrange berrange at redhat.com
Tue Mar 12 10:31:06 UTC 2013


On Thu, Mar 07, 2013 at 08:55:13PM +0100, Marc-André Lureau wrote:
> The virt-viewer connection file can now have a version=0.5 field. If
> the virt-viewer version opening the connection doesn't provide at
> least that version, an error is raised with the version required.

What is the anticipated use case for this ?  IMHO version based checks
for user visible features are almost always the wrong thing todo,
particularly if features can be disabled at build time with configure
args. I prefer to see explicit feature checks

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the virt-tools-list mailing list