[virt-tools-list] [PATCH virt-viewer] app: move display on client monitors with --full-screen

Hans de Goede hdegoede at redhat.com
Thu May 23 07:56:54 UTC 2013


ACK.

On 05/22/2013 09:40 PM, Marc-André Lureau wrote:
> There used to be a check to fullscreen the only visible display on
> current monitor, by checking the number of visible monitors. Now that
> fullscreen is independant for each display, and goes on current monitor,
> it's useless.
>
> However, this code path is still used for the app --full-screen, at
> startup time. And it is still nicer to open the display on respective
> client monitors, rather than all on current monitor.
> ---
>   src/virt-viewer-app.c | 10 +++-------
>   1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
> index 539c4a4..c2ecc67 100644
> --- a/src/virt-viewer-app.c
> +++ b/src/virt-viewer-app.c
> @@ -631,16 +631,12 @@ viewer_window_focus_out_cb(GtkWindow *window G_GNUC_UNUSED,
>   }
>
>   static void
> -app_window_try_fullscreen(VirtViewerApp *self, VirtViewerWindow *win, gint nth)
> +app_window_try_fullscreen(VirtViewerApp *self G_GNUC_UNUSED,
> +                          VirtViewerWindow *win, gint nth)
>   {
>       GdkScreen *screen = gdk_screen_get_default();
> -    gboolean move =
> -        virt_viewer_app_get_n_windows_visible(self) > 1 ||
> -        self->priv->fullscreen_auto_conf;
>
> -    if (!move)
> -        nth = -1;
> -    else if (nth >= gdk_screen_get_n_monitors(screen)) {
> +    if (nth >= gdk_screen_get_n_monitors(screen)) {
>           DEBUG_LOG("skipping display %d", nth);
>           return;
>       }
>




More information about the virt-tools-list mailing list