[virt-tools-list] virt-manager: show read-only check button when add fs for lxc container

Cole Robinson crobinso at redhat.com
Mon Nov 25 15:18:13 UTC 2013


On 11/25/2013 01:51 AM, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> 
> show read-only check button when add fs for lxc container.
> 
> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> ---
>  virtManager/addhardware.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/virtManager/addhardware.py b/virtManager/addhardware.py
> index fb7c236..fa534cc 100644
> --- a/virtManager/addhardware.py
> +++ b/virtManager/addhardware.py
> @@ -307,6 +307,7 @@ class vmmAddHardware(vmmGObjectUI):
>          simple_store_set("fs-wrpolicy-combo", VirtualFilesystem.WRPOLICIES)
>          self.show_pair_combo("fs-type", self.conn.is_openvz())
>          self.show_check_button("fs-readonly", self.conn.is_qemu())
> +        self.show_check_button("fs-readonly", self.conn.is_lxc())
>  
>          # Smartcard widgets
>          combo = self.widget("smartcard-mode")
> 

Just use 'self.conn.is_qemu() or self.conn.is_lxc()'. The patch as is will
actually hide the readonly checkbox for qemu.

Please also use [PATCH virt-manager] as a subject prefix for virt-manager
patches. git format-patch --subject-prefix="PATCH virt-manager"

Thanks,
Cole




More information about the virt-tools-list mailing list