[virt-tools-list] [virt-manager PATCH]RFC: addhardware: Add controller options to addhw wizard

[chenhanxiao at cn.fujitsu.com]

> -----Original Message-----
> From: Cole Robinson [mailto:crobinso at redhat.com]
> Sent: Wednesday, April 09, 2014 6:54 AM
> To: Chen, Hanxiao/陈 晗霄; virt-tools-list at redhat.com
> Subject: Re: [virt-tools-list] [virt-manager PATCH]RFC: addhardware: Add
> controller options to addhw wizard
> 
> On 04/04/2014 06:04 AM, Chen Hanxiao wrote:
> > Add controller options to addhw wizard.
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=1076607
> >
> > Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> 
> General idea is fine. A few suggestions:
> 
> - Move addhw->controller list option to the same list position as a VM
> controller device appears. So, after 'disk'
> 
> - If a controller doesn't have any 'model' options, we should hide the 'model'
> row/combo
> 
> The harder bit is that there's now the addhardware->controller and
> details->controller pages are out of sync. I'd suggest only showing the same
> controller models that we will show in the details page, (USB2/USB3 for usb,
> virtio-serial/default for scsi). I don't know if we should even offer an
> option for a PCI controller, since I think that's all an immutable part of the
> chipset and there's no way for the user to actually configure it directly, but
> maybe that's changed with qemu q35.
> 
> - Cole

Thanks, v2 will do some improvements.

-Chen