[virt-tools-list] [virt-manager PATCH 1/4] addhardware: userange to initialize page number

[Chen Hanxiao]

On 04/16/2014 07:30 PM, Giuseppe Scrivano wrote:
> Chen Hanxiao <chenhanxiao at cn.fujitsu.com> writes:
>
>> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
>> ---
>>   virtManager/addhardware.py | 33 +++++++++++++++++----------------
>>   1 file changed, 17 insertions(+), 16 deletions(-)
>>
>> diff --git a/virtManager/addhardware.py b/virtManager/addhardware.py
>> index bd999cc..39ec63f 100644
>> --- a/virtManager/addhardware.py
>> +++ b/virtManager/addhardware.py
>> @@ -42,22 +42,23 @@ from virtManager.storagebrowse import vmmStorageBrowser
>>   from virtManager.baseclass import vmmGObjectUI
>>   from virtManager.addstorage import vmmAddStorage
>>   
>> -PAGE_ERROR = 0
>> -PAGE_DISK = 1
>> -PAGE_NETWORK = 2
>> -PAGE_INPUT = 3
>> -PAGE_GRAPHICS = 4
>> -PAGE_SOUND = 5
>> -PAGE_HOSTDEV = 6
>> -PAGE_CHAR = 7
>> -PAGE_VIDEO = 8
>> -PAGE_WATCHDOG = 9
>> -PAGE_FILESYSTEM = 10
>> -PAGE_SMARTCARD = 11
>> -PAGE_USBREDIR = 12
>> -PAGE_TPM = 13
>> -PAGE_RNG = 14
>> -PAGE_PANIC = 15
>> +(PAGE_ERROR,
>> +PAGE_DISK,
>> +PAGE_NETWORK,
>> +PAGE_INPUT,
>> +PAGE_GRAPHICS,
>> +PAGE_SOUND,
>> +PAGE_HOSTDEV,
>> +PAGE_CHAR,
>> +PAGE_VIDEO,
>> +PAGE_WATCHDOG,
>> +PAGE_FILESYSTEM,
>> +PAGE_SMARTCARD,
>> +PAGE_USBREDIR,
>> +PAGE_TPM,
>> +PAGE_RNG,
>> +PAGE_PANIC,
>> +) = range(0, 16)
> even if Emacs would format that differently (indenting with an empty
> space), we use both styles in virt-manager and pylint doesn't complain,
> so ACK.
>
> Giuseppe
Thanks, pushed this one.

- Chen
>
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
>