[virt-tools-list] [virt-manager PATCH v2] details: introduce show_remove_button method

[Chen Hanxiao]

On 04/24/2014 11:31 PM, Cole Robinson wrote:
> On 04/21/2014 11:28 PM, Chen Hanxiao wrote:
>> Sometimes we need to set remove button as none-sensitive.
>>
>> This patch introduces show_remove_button method as
>> the only interface for showing/removing,
>> also easy to maintain.
>>
>> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
>> ---
>> v2: remove checks in refresh_* function,
>> invoked show_remove_button in hw_selected
>>
>>   virtManager/details.py | 43 +++++++++++++++++++++++++++++++++++--------
>>   1 file changed, 35 insertions(+), 8 deletions(-)
>>
> TBH I still don't like moving this logic away from where it already is. If we
> had to do this for many devices I can understand that a bit, but it's a very
> special case (and even USB _is_ removable we just don't implement it). So NACK
>
> - Cole
>
> _

Thanks, I see.

- Chen
> ______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
>