[virt-tools-list] [virt-viewer] Only wait for shutoff domains when --wait is used

Christophe Fergeau cfergeau at redhat.com
Tue Aug 5 13:59:28 UTC 2014


On Tue, Aug 05, 2014 at 09:47:58AM -0400, Marc-André Lureau wrote:
> 
> Hi
> 
> ----- Original Message -----
> 
> > Hm, It seems that this was always broken. I've even gotten accustomed to this
> > behavior. But it's obviously not supposed to wait unless --wait is
> > specified. ACK.
> 
> Same for me. {erhaps it's a good idea to keep the default to be --wait, and make it a silent/hidden option? Then add a --no-wait instead
> 

I had never noticed that behaviour until now, but since you and Jonathon
say you were accustomed to it, it's likely more people are relying on
it. With that in mind, it's indeed better to keep the current behaviour
the default to avoid breaking things people are used to.

Rather than changing the code to match the documentation, we can go the
other way, and just deprecate --wait and document it does nothing (which
is mostly the case currently, --wait waits for the domain to be created
if it does not exist, or for the spice/vnc server to start in the
guest).

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20140805/b1d633b2/attachment.sig>


More information about the virt-tools-list mailing list