[virt-tools-list] [virt-viewer] Only wait for shutoff domains when --wait is used

[Jonathon Jongsma]

On Mon, 2014-08-11 at 09:31 +0100, Daniel P. Berrange wrote:
> On Tue, Aug 05, 2014 at 10:00:11AM -0400, Jonathon Jongsma wrote:
> > ----- Original Message -----
> > > From: "Marc-André Lureau" <mlureau at redhat.com>
> > > To: "Jonathon Jongsma" <jjongsma at redhat.com>
> > > Cc: "Christophe Fergeau" <cfergeau at redhat.com>, virt-tools-list at redhat.com
> > > Sent: Tuesday, August 5, 2014 8:47:58 AM
> > > Subject: Re: [virt-tools-list] [virt-viewer] Only wait for shutoff domains when	--wait is used
> > > 
> > > 
> > > Hi
> > > 
> > > ----- Original Message -----
> > > 
> > > > Hm, It seems that this was always broken. I've even gotten accustomed to
> > > > this
> > > > behavior. But it's obviously not supposed to wait unless --wait is
> > > > specified. ACK.
> > > 
> > > Same for me. {erhaps it's a good idea to keep the default to be --wait, and
> > > make it a silent/hidden option? Then add a --no-wait instead
> > > 
> > 
> > 
> > I'm not sure that defaulting to --wait is the right thing to do though. 
> > I do kind of like the current behavior where it waits for un-started
> > domains, but I don't think I'd want it to wait for un-created domains. 
> > I suspect that most people would probably prefer an error message if
> > they tried to start virt-viewer for a domain that doesn't exist.
> 
> The --wait arg was explicitly needing to wait for domains that don't
> even exist in libvirt to solve race conditions in domain provisioning.
> eg spawn 'virt-viewer --wait foo' and then do 'virDomainCreateXML'
> to provision the new guest and the console is thus able to catch
> early boot display.


Right, I wasn't arguing that we shouldn't wait for un-created domains
when --wait is specified.  I was only talking about the default behavior
(when --wait is not specified).

Jonathon