[virt-tools-list] [PATCH virt-viewer v3 3/3] Write vm name to config file as comment

[Marc-André Lureau]

On Wed, Aug 6, 2014 at 9:19 PM, Jonathon Jongsma <jjongsma at redhat.com>
wrote:

> +        if (error) {
> +            g_warning("Unable to get comment from key file: %s",
> error->message);
>


I get this warning, while I think this is a normal condition. Shouldn't it
be a g_debug instead?


> +            g_clear_error(&error);
> +        } else {
> +            if (!comment || *comment == '\0')
> +                g_key_file_set_comment(priv->config, priv->uuid, NULL,
> priv->guest_name, NULL);
> +        }
>

So is this patch supposed to add a comment if it doesn't exist? How is it
supposed to look like? It would have been nice to add a comment in commit
log or in man page if it's supposed to be edited by user?



-- 
Marc-André Lureau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20140822/810e160c/attachment.htm>