[virt-tools-list] [libvirt] ANNOUNCE: virt-manager 1.1.0 released

[Jason Helfman]

On Tue, Dec 2, 2014 at 7:28 AM, Cole Robinson <crobinso at redhat.com> wrote:

> On 12/01/2014 08:52 PM, Jason Helfman wrote:
>
>> On Fri, Nov 21, 2014 at 10:13 AM, Jason Helfman <jgh at freebsd.org
>> <mailto:jgh at freebsd.org>> wrote:
>>
>>     On Fri, Nov 21, 2014 at 5:09 AM, Cole Robinson <crobinso at redhat.com
>>     <mailto:crobinso at redhat.com>> wrote:
>>
>>         On 11/20/2014 11:15 PM, Jason Helfman wrote:
>>
>>             Hello,
>>
>>             I was able to get this imported for FreeBSD, but had to
>> implement
>>             a couple of
>>             patches for it to work:
>>
>>             https://svnweb.freebsd.org/__ports/head/deskutils/virt-__
>> manager/files/patch-__virtManager_config.py?view=__markup&pathrev=372972
>>             <https://svnweb.freebsd.org/ports/head/deskutils/virt-
>> manager/files/patch-virtManager_config.py?view=markup&pathrev=372972>
>>             https://svnweb.freebsd.org/__ports/head/deskutils/virt-__
>> manager/files/patch-__virtManager_console.py?view=__markup&pathrev=372972
>>             <https://svnweb.freebsd.org/ports/head/deskutils/virt-
>> manager/files/patch-virtManager_console.py?view=markup&pathrev=372972>
>>
>>             This was taken obtained from:
>>             https://build.opensuse.org/__package/view_file/openSUSE:__
>> Factory/virt-manager/virt-__manager-Gtk-30.patch#
>>             <https://build.opensuse.org/package/view_file/openSUSE:
>> Factory/virt-manager/virt-manager-Gtk-30.patch#>
>>
>>             And is reference by a bug here:
>>             https://bugzilla.suse.com/__show_bug.cgi?id=901869
>>             <https://bugzilla.suse.com/show_bug.cgi?id=901869>
>>
>>             Comments and suggestions are welcome...
>>
>>
>>         Thanks for the heads up. I added a comment in that suse bug
>> asking for
>>         the patch to be submitted upstream. But if that doesn't
>> materialize in
>>         a week, ping back here
>>
>> Any word?
>>
>>
> Nope. And looking at the suse RPMs I see a ton of patches that they've
> never submitted upstream, some which are clear bug fixes... quite
> frustrating. I've attached their patch, can you try it locally and ensure
> it fixes your issues? If so I'll push it upstream
>
> Thanks,
> Cole
>
>
Works great. Thanks!

It is too bad that their patches aren't contributed back. My advice is use
their patches (if they work) and note "Obtained from SUSE" in commitlogs.
When their software build process breaks with the next update, they will
look at the logs and find out why. This may encourage them to contribute
more to the project :)

Thanks,
Jason



-- 
Jason Helfman          | FreeBSD Committer
jgh at FreeBSD.org     | http://people.freebsd.org/~jgh  | The Power to Serve
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20141202/6f92f99d/attachment.htm>