[virt-tools-list] [PATCH] URL installs: remove hasFile("") check

Gabriel de Perthuis g2p.code at gmail.com
Mon Dec 8 21:43:38 UTC 2014


Specialised proxies like apt-cacher-ng disallow directory listing.
OSDistro subclasses do have checks for known files and they are
sufficient.
---
 virtinst/urlfetcher.py | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/virtinst/urlfetcher.py b/virtinst/urlfetcher.py
index 5a8a98d..25f7066 100644
--- a/virtinst/urlfetcher.py
+++ b/virtinst/urlfetcher.py
@@ -125,15 +125,10 @@ class _URIImageFetcher(_ImageFetcher):
     Base class for downloading from FTP / HTTP
     """
     def hasFile(self, filename):
         raise NotImplementedError
 
-    def prepareLocation(self):
-        if not self.hasFile(""):
-            raise ValueError(_("Opening URL %s failed.") %
-                              (self.location))
-
 
 class _HTTPImageFetcher(_URIImageFetcher):
     def hasFile(self, filename):
         try:
             path = self._make_path(filename)
-- 
2.1.2.457.g0cd6422




More information about the virt-tools-list mailing list