[virt-tools-list] [virt-viewer] [PATCH 07/15] nsis: add libwinpthread-1.dll

[Christophe Fergeau]

Hey,

On Wed, Dec 10, 2014 at 11:01:55AM +0100, Fabiano Fidêncio wrote:
> On Wed, Dec 10, 2014 at 10:11 AM, Christophe Fergeau
> <cfergeau at redhat.com> wrote:
> > Hey,
> >
> > On Tue, Dec 09, 2014 at 05:13:37PM +0100, Fabiano Fidêncio wrote:
> >> libwinpthread-1.dll is a dependency of libvirt
> >
> > I assume this means after this series virsh.exe/virt-viewer.exe can be
> > successfully launched?
> 
> Hmm. virsh depends on a few unix specific stuff for authentication,
> IIRC. So, probably it can be launched, but dunno how useful it could
> be.
> 
> > This was not necessarily the case with past
> > builds of the installer (forgot if this was msi or nsis).
> 
> It has been part of the .msi installter, at least since f20 and the
> reason to add it to .nsis build is basically because of a warning
> poping-up in the screen, complaining that libwinpthread was missed.

Sorry, I was not very clear, this is basically what I was saying/asking:
in the past, virsh.exe/virt-viewer.exe would not start because of
missing dlls. Are the dlls you add enough for a successful startup of
these binaries? (making sure that they actually work after starting up
is indeed a different thing which is not related to this series). It
seems the answer is yes, so it's all good :)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20141210/126ab6bb/attachment.sig>