[virt-tools-list] [virt-manager PATCH] tests/testdriver: Don't use invalid uid values

[Cole Robinson]

On 12/10/2014 04:08 AM, Martin Kletzander wrote:
> The value 4294967295 used in the testdriver for sheepdog volume is not
> valid on 32bit systems as it won't fit in uid_t and libvirt will fail
> parsing that.
>
> Running "./setup.py test" then fails with:
>
>    raise libvirtError('virConnectOpenAuth() failed')
>    libvirt.libvirtError: XML error: malformed owner element
>
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> ---
>   tests/testdriver.xml | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/testdriver.xml b/tests/testdriver.xml
> index d259a6e..d65f314 100644
> --- a/tests/testdriver.xml
> +++ b/tests/testdriver.xml
> @@ -1830,8 +1830,8 @@ ba</description>
>         <format type='unknown'/>
>         <permissions>
>           <mode>0600</mode>
> -        <owner>4294967295</owner>
> -        <group>4294967295</group>
> +        <owner>-1</owner>
> +        <group>-1</group>
>         </permissions>
>       </target>
>     </volume>
>

ACK, though I got that from libvirt's tests directory:

$ git grep 4294967295 tests/storagevolxml2xmlout/
tests/storagevolxml2xmlout/vol-gluster-dir.xml:      <owner>4294967295</owner>
tests/storagevolxml2xmlout/vol-gluster-dir.xml:      <group>4294967295</group>
tests/storagevolxml2xmlout/vol-sheepdog.xml:      <owner>4294967295</owner>
tests/storagevolxml2xmlout/vol-sheepdog.xml:      <group>4294967295</group>

- Cole