[virt-tools-list] [PATCH virt-viewer] display-vnc: set correct window size when vnc is initialized

Pavel Grunt pgrunt at redhat.com
Wed Dec 10 13:06:58 UTC 2014


Thank you for the review, I am sending v2.

Pavel

> 
> Pavel,
> 
> I'd go for a short-log as something like:
> 
> display-vnc: fix zoom-level set by command line
> 
> On Wed, Dec 10, 2014 at 10:39 AM, Pavel Grunt <pgrunt at redhat.com>
> wrote:
> > The display is shrinked when connecting to a vnc guest. Also
> > the "zoom" option is not working for vnc guests.
> 
> s/shrinked/shrunk
> 
> > This problem can be solved by emitting "display-desktop-resize"
> > signal when vnc is initialized.
> 
> I'd go for something with more emphasis on the zoom-level problem and
> then describing that it also fixes the shrunk display.
> 
> 
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=1170071
> > ---
> >  src/virt-viewer-display-vnc.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/src/virt-viewer-display-vnc.c
> > b/src/virt-viewer-display-vnc.c
> > index 1f7c11b..6605b1b 100644
> > --- a/src/virt-viewer-display-vnc.c
> > +++ b/src/virt-viewer-display-vnc.c
> > @@ -118,6 +118,7 @@ virt_viewer_display_vnc_initialized(VncDisplay
> > *vnc G_GNUC_UNUSED,
> >  {
> >      virt_viewer_display_set_show_hint(display,
> >                                        VIRT_VIEWER_DISPLAY_SHOW_HINT_READY,
> >                                        TRUE);
> > +    g_signal_emit_by_name(display, "display-desktop-resize");
> >  }
> >
> >  static void
> > --
> > 1.9.3
> >
> > _______________________________________________
> > virt-tools-list mailing list
> > virt-tools-list at redhat.com
> > https://www.redhat.com/mailman/listinfo/virt-tools-list
> 
> ACK with the changes.
> 
> Best Regards,
> --
> Fabiano Fidêncio
> 




More information about the virt-tools-list mailing list