[virt-tools-list] [virt-viewer] spec: Update mingw BuildRequires

Daniel P. Berrange berrange at redhat.com
Tue Dec 16 13:24:05 UTC 2014


On Tue, Dec 16, 2014 at 02:02:16PM +0100, Christophe Fergeau wrote:
> Several new dependencies were added with the recent msi installer
> update.
> ---
>  mingw-virt-viewer.spec.in | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/mingw-virt-viewer.spec.in b/mingw-virt-viewer.spec.in
> index ea8c20b..599ca8a 100644
> --- a/mingw-virt-viewer.spec.in
> +++ b/mingw-virt-viewer.spec.in
> @@ -24,12 +24,16 @@ Source0:        ftp://virt-manager.org/downloads/virt-viewer/virt-viewer-%{versi
>  
>  BuildRequires:  mingw32-filesystem >= 23
>  BuildRequires:  mingw64-filesystem >= 23
> +BuildRequires:  mingw32-glib-networking
> +BuildRequires:  mingw64-glib-networking

I'm not seeing any reference to this in our source tree - where is
it used ?

>  BuildRequires:  mingw32-glib2 >= @GLIB2_REQUIRED@
>  BuildRequires:  mingw64-glib2 >= @GLIB2_REQUIRED@
>  BuildRequires:  mingw32-gstreamer-plugins-bad-free
>  BuildRequires:  mingw64-gstreamer-plugins-bad-free
>  BuildRequires:  mingw32-gstreamer-plugins-good
>  BuildRequires:  mingw64-gstreamer-plugins-good
> +BuildRequires:  mingw32-libgovirt
> +BuildRequires:  mingw64-libgovirt
>  BuildRequires:  mingw32-gtk2 >= @GTK2_REQUIRED@
>  BuildRequires:  mingw64-gtk2 >= @GTK2_REQUIRED@
>  BuildRequires:  mingw32-libusbx
> @@ -42,6 +46,8 @@ BuildRequires:  mingw32-gtk-vnc >= @GTK_VNC1_REQUIRED@
>  BuildRequires:  mingw64-gtk-vnc >= @GTK_VNC1_REQUIRED@
>  BuildRequires:  mingw32-readline
>  BuildRequires:  mingw64-readline
> +BuildRequires:  mingw32-rest
> +BuildRequires:  mingw64-rest

Is this used directly, or only via libgovirt ? It is already a dep of
mingw*-libgovirt, so unless we directly use it too, we don't need to
list it here.

>  BuildRequires:  mingw32-spice-glib
>  BuildRequires:  mingw64-spice-glib
>  BuildRequires:  mingw32-spice-gtk >= @SPICE_GTK_REQUIRED@
> @@ -54,6 +60,8 @@ BuildRequires:  intltool
>  BuildRequires:  icoutils
>  BuildRequires:  dos2unix
>  BuildRequires:  hicolor-icon-theme
> +BuildRequires:  adwaita-icon-theme
> +BuildRequires:  hwdata
>  BuildRequires:  gnome-icon-theme
>  BuildRequires:  msitools >= 0.92-2

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the virt-tools-list mailing list