[virt-tools-list] [PATCH virt-viewer] Load ui files first from installed location

[Jonathon Jongsma]

Hey, 

----- Original Message -----
> From: "Christophe Fergeau" <cfergeau at redhat.com>
> To: "Jonathon Jongsma" <jjongsma at redhat.com>
> Cc: virt-tools-list at redhat.com
> Sent: Friday, January 17, 2014 7:43:44 AM
> Subject: Re: [virt-tools-list] [PATCH virt-viewer] Load ui files first from installed location
> 
> Hey,
> 
> On Thu, Jan 16, 2014 at 12:36:15PM -0600, Jonathon Jongsma wrote:
> > virt_viewer_util_load_ui() looks first in the current directory, and then
> > looks
> > in the system data dirs for a ui file to load, but if you install
> > virt-viewer in
> > a different prefix, it will load the system UI file rather than the one
> > from the
> > install prefix. Try to load the ui file from pkgdatadir first.
> 
> I'm not sure we should try to use g_get_system_data_dirs() at all as I
> generally don't expect having the application look in /usr/share when I set
> $prefix.
> 
> Christophe
> 


it looks like the system data dirs stuff was added in commit 1002a220 to fix a problem on windows.  I'm not sure of all the details since the changelog just says "Load UI file correctly, to fix Windows support".  (side note: it would be nice if the commit logs had more details about what is being fixed, and why). So, I guess we should probably leave that in for the windows port, though it will never be used on linux.

Jonathon